Autodeploy broken due to instanciated left-over files in ./config/ dir

[tlvu]

The .gitignore syntax was wrong. Regression from v2.0.0 (#399).

Non-breaking changes

• Fix .gitignore syntax

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

[mishaschwartz]

This will match all config directories recursively which is not what we want.

From the gitignore documentation:

If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.

I think we need to change it to:

/config/

instead

[tlvu]

You are absolutely right ! Thanks for catching this enormous error !!! Fixed.

[crim-jenkins-bot]

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2414/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-broken-autodeploy
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-133.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1494/

NOTEBOOK TEST RESULTS

    
[2024-01-16T19:27:09.074Z] ============================= test session starts ==============================
[2024-01-16T19:27:09.075Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2024-01-16T19:27:09.075Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-01-16T19:27:09.075Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2024-01-16T19:27:09.075Z] collected 264 items
[2024-01-16T19:27:09.075Z] 
[2024-01-16T19:27:18.967Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-01-16T19:27:53.678Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-01-16T19:27:58.627Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-01-16T19:28:07.678Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 17%]
[2024-01-16T19:28:17.679Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 19%]
[2024-01-16T19:28:25.619Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 22%]
[2024-01-16T19:37:42.399Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 27%]
[2024-01-16T19:37:42.399Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 27%]
[2024-01-16T19:37:48.361Z] ...............                                                          [ 33%]
[2024-01-16T19:37:58.248Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-01-16T19:38:05.170Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 37%]
[2024-01-16T19:38:21.341Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 39%]
[2024-01-16T19:38:27.690Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-01-16T19:38:37.824Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-01-16T19:42:35.242Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-01-16T19:43:51.821Z] .............                                                            [ 54%]
[2024-01-16T19:43:55.642Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-01-16T19:43:58.243Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-01-16T19:44:16.052Z] .................                                                        [ 65%]
[2024-01-16T19:44:24.958Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 68%]
[2024-01-16T19:44:26.883Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-01-16T19:44:54.680Z] ........F                                                                [ 71%]
[2024-01-16T19:45:05.088Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 76%]
[2024-01-16T19:45:14.402Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 78%]
[2024-01-16T19:45:15.790Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 78%]
[2024-01-16T19:45:18.850Z] ......                                                                   [ 81%]
[2024-01-16T19:45:28.853Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 81%]
[2024-01-16T19:45:43.546Z] .............                                                            [ 86%]
[2024-01-16T19:45:53.547Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2024-01-16T19:47:40.031Z] ....s.                                                                   [ 89%]
[2024-01-16T19:47:50.004Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2024-01-16T19:48:07.446Z] ...                                                                      [ 90%]
[2024-01-16T19:48:25.560Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2024-01-16T19:48:50.683Z] ......                                                                   [ 93%]
[2024-01-16T19:48:53.444Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-01-16T19:51:33.546Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-01-16T19:51:33.546Z] 
[2024-01-16T19:51:33.546Z] =================================== FAILURES ===================================
    
  

[crim-jenkins-bot]

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2415/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-broken-autodeploy
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1495/

NOTEBOOK TEST RESULTS

    
[2024-01-16T19:44:29.898Z] ============================= test session starts ==============================
[2024-01-16T19:44:29.898Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2024-01-16T19:44:29.898Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master@2
[2024-01-16T19:44:29.898Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2024-01-16T19:44:29.898Z] collected 264 items
[2024-01-16T19:44:29.898Z] 
[2024-01-16T19:44:40.840Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-01-16T19:45:07.082Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-01-16T19:45:14.951Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-01-16T19:45:23.650Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 17%]
[2024-01-16T19:45:35.168Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 19%]
[2024-01-16T19:45:41.724Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 22%]
[2024-01-16T19:53:15.241Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 27%]
[2024-01-16T19:53:15.241Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 27%]
[2024-01-16T19:53:20.951Z] ...............                                                          [ 33%]
[2024-01-16T19:53:30.198Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-01-16T19:53:37.109Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 37%]
[2024-01-16T19:53:52.913Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 39%]
[2024-01-16T19:53:57.678Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-01-16T19:54:02.444Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-01-16T19:56:59.119Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-01-16T19:58:15.492Z] .............                                                            [ 54%]
[2024-01-16T19:58:18.607Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-01-16T19:58:21.187Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-01-16T19:58:37.733Z] .................                                                        [ 65%]
[2024-01-16T19:58:45.482Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 68%]
[2024-01-16T19:58:47.395Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-01-16T19:59:05.500Z] ........F                                                                [ 71%]
[2024-01-16T19:59:15.057Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 76%]
[2024-01-16T19:59:25.029Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 78%]
[2024-01-16T19:59:26.413Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 78%]
[2024-01-16T19:59:29.232Z] ......                                                                   [ 81%]
[2024-01-16T19:59:35.835Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 81%]
[2024-01-16T19:59:51.458Z] .............                                                            [ 86%]
[2024-01-16T20:00:01.933Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2024-01-16T20:00:48.842Z] ....s.                                                                   [ 89%]
[2024-01-16T20:00:57.047Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2024-01-16T20:01:12.570Z] ...                                                                      [ 90%]
[2024-01-16T20:01:27.467Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2024-01-16T20:01:50.033Z] ......                                                                   [ 93%]
[2024-01-16T20:01:52.248Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-01-16T20:04:26.397Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-01-16T20:04:26.397Z] 
[2024-01-16T20:04:26.397Z] =================================== FAILURES ===================================
    
  

[mishaschwartz]

Looks good! Sorry for introducing this bug in the first place.

Also, just mentioning that this is another good reason for #362

[tlvu]

Looks good! Sorry for introducing this bug in the first place.

We are all human, I just proved it in this own PR! That's what peer reviewer is for.

Also, just mentioning that this is another good reason for #362

I was already sold by your idea. In comment #362 (review) I was only concerned about docker-compose, not about the idea to cleanly separate the instantiated files to its own subtree.

[crim-jenkins-bot]

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2416/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : fix-broken-autodeploy
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-133.rdext.crim.ca

Infrastructure deployment failed. Instance has not been destroyed. @matprov