Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating an offer it does not recognize the account currency #6157

Closed
chimp1984 opened this issue Apr 24, 2022 · 4 comments · Fixed by #6160
Closed

When creating an offer it does not recognize the account currency #6157

chimp1984 opened this issue Apr 24, 2022 · 4 comments · Fixed by #6160

Comments

@chimp1984
Copy link
Contributor

With current main branch version If the user has set up an account and has the offer book set to Show all currencies and creates an offer they get displayed the popup that they need to set up an account. Only if the user selects the currency of their account first they can create an offer.

@ghost
Copy link

ghost commented Apr 24, 2022

I wasn't able to reproduce it - it seems to be an edge case scenario. Could you provide more details about your setup (f.e. preferred currency in settings, existing accounts, market etc.)?

reproduce

@ghost
Copy link

ghost commented Apr 24, 2022

UPDATE:
I switched preferred currency to GBP, I didn't had GBP account. Now I see "need to set up an account." popup always when trying to create new FIAT offer, no matter of chosen currency in filters.

@ripcurlx It seems to be related with Improve navigation structure.

@chimp1984
Copy link
Contributor Author

I used an new app with AliPay account. Had offerbook with ShowAll currencies. The clicked create offer and got the popup.
Only if I selected CNY first I could create an offer.

@ripcurlx
Copy link
Contributor

I switched preferred currency to GBP, I didn't had GBP account. Now I see "need to set up an account." popup always when trying to create new FIAT offer, no matter of chosen currency in filters.

Yes, both cases are because of the default currency set, with no payment account available. I'll have a look to make this more robust against such use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants