Enhance CI Workflow and Update Protobuf Generation #126
Conversation
|
Warning Rate limit exceeded@naveensrinivasan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 22 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes in this pull request focus on modifications to the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
naveensrinivasan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
gen/api/v1/service.pb.gois excluded by!**/*.pb.go,!**/gen/**
📒 Files selected for processing (1)
Makefile(1 hunks)
🔇 Additional comments (4)
Makefile (4)
40-40: LGTM: Appropriate dependency chain for git-porcelain
The addition of buf-generate to the git-porcelain target ensures that protobuf files are generated before checking for uncommitted changes, which helps catch any protobuf-related modifications early in the CI process.
43-45: LGTM: Clear separation of generation and installation concerns
The buf-generate target appropriately depends on install-buf, ensuring the tool is available before attempting generation.
66-66: LGTM: Appropriate addition to default target
Adding buf-generate to the all target ensures protobuf files are generated during standard build processes, maintaining consistency between proto definitions and generated code.
68-68: LGTM: Proper .PHONY declaration
The .PHONY declaration has been appropriately updated to include the new targets, ensuring make correctly handles these targets as commands rather than files.
naveensrinivasan
force-pushed
the
naveen/buf
branch
5 times, most recently
from
03c85ba
to
0787f5f
Compare
**Description:** - **CI Workflow Enhancements:** - Updated the GitHub Actions workflow to include a new `buf-generate` target in the `git-porcelain` task. This ensures that protobuf files are generated as part of the CI checks. - Added a conditional installation of `buf` in the CI environment. If `buf` is not installed, it will be automatically downloaded and installed during CI runs. This prevents build failures due to missing dependencies in CI environments. - **Makefile Updates:** - Introduced a new `buf-generate` target in the Makefile, which depends on the `install-buf` target. This target runs `buf generate` to regenerate protobuf files. - Added `install-buf` target to conditionally install `buf` only in CI environments. This ensures that local development environments are not affected if `buf` is not installed. - Updated the `all` target to include `buf-generate`, ensuring that all necessary build steps are executed. - **Protobuf File Update:** - Updated the `gen/api/v1/service.pb.go` file to reflect changes in the protobuf generation. This includes minor changes in the file descriptor bytes, likely due to updates in the source `.proto` files or the `buf` tool version. **Impact:** - These changes improve the robustness of the CI pipeline by ensuring all necessary tools and steps are included. - The updates to the protobuf files ensure that the generated code is up-to-date with the latest `.proto` definitions. **Notes:** - Developers should ensure `buf` is installed locally if they wish to run `buf-generate` outside of CI. - The changes in the protobuf file are automatically generated and should be reviewed to ensure compatibility with existing code. Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/buf
branch
from
0787f5f
to
229252d
Compare
Description:
CI Workflow Enhancements:
buf-generatetarget in thegit-porcelaintask. This ensures that protobuf files are generated as part of the CI checks.bufin the CI environment. Ifbufis not installed, it will be automatically downloaded and installed during CI runs. This prevents build failures due to missing dependencies in CI environments.Makefile Updates:
buf-generatetarget in the Makefile, which depends on theinstall-buftarget. This target runsbuf generateto regenerate protobuf files.install-buftarget to conditionally installbufonly in CI environments. This ensures that local development environments are not affected ifbufis not installed.alltarget to includebuf-generate, ensuring that all necessary build steps are executed.Protobuf File Update:
gen/api/v1/service.pb.gofile to reflect changes in the protobuf generation. This includes minor changes in the file descriptor bytes, likely due to updates in the source.protofiles or thebuftool version.Impact:
.protodefinitions.Notes:
bufis installed locally if they wish to runbuf-generateoutside of CI.Summary by CodeRabbit
New Features
Improvements