Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance CI Workflow and Update Protobuf Generation #126

Merged
merged 1 commit into from
Nov 12, 2024

Commits on Nov 12, 2024

  1. **Title: Enhance CI Workflow and Update Protobuf Generation**

    **Description:**
    
    - **CI Workflow Enhancements:**
      - Updated the GitHub Actions workflow to include a new `buf-generate` target in the `git-porcelain` task. This ensures that protobuf files are generated as part of the CI checks.
      - Added a conditional installation of `buf` in the CI environment. If `buf` is not installed, it will be automatically downloaded and installed during CI runs. This prevents build failures due to missing dependencies in CI environments.
    
    - **Makefile Updates:**
      - Introduced a new `buf-generate` target in the Makefile, which depends on the `install-buf` target. This target runs `buf generate` to regenerate protobuf files.
      - Added `install-buf` target to conditionally install `buf` only in CI environments. This ensures that local development environments are not affected if `buf` is not installed.
      - Updated the `all` target to include `buf-generate`, ensuring that all necessary build steps are executed.
    
    - **Protobuf File Update:**
      - Updated the `gen/api/v1/service.pb.go` file to reflect changes in the protobuf generation. This includes minor changes in the file descriptor bytes, likely due to updates in the source `.proto` files or the `buf` tool version.
    
    **Impact:**
    - These changes improve the robustness of the CI pipeline by ensuring all necessary tools and steps are included.
    - The updates to the protobuf files ensure that the generated code is up-to-date with the latest `.proto` definitions.
    
    **Notes:**
    - Developers should ensure `buf` is installed locally if they wish to run `buf-generate` outside of CI.
    - The changes in the protobuf file are automatically generated and should be reviewed to ensure compatibility with existing code.
    
    Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
    naveensrinivasan committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    229252d View commit details
    Browse the repository at this point in the history