-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use google/wire instead of fx #133
Merged
Merged
Commits on Nov 14, 2024
-
- refactored the custom cmd Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b4400e5 - Browse repository at this point
Copy the full SHA b4400e5View commit details -
Removed the storage from cmd that is not server
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8f47231 - Browse repository at this point
Copy the full SHA 8f47231View commit details
Commits on Nov 15, 2024
-
Refactor codebase to remove
go.uber.org/fx
dependency and update st……orage initialization** - Remove dependency on `go.uber.org/fx` and associated dependency injection setup. - Simplify `main.go` by removing `fx.App` and directly executing the root command. - Modify `cmd/root/root.go`: - Rename `options` struct to `Options` to make it exportable. - Update `AddFlags` method to use exported fields. - Add `PersistentPreRun` function to start the pprof server if enabled. - Change `New` function signature to return `(*cobra.Command, error)` instead of just `*cobra.Command`. - Modify `cmd/server/server.go`: - Add `StorageType` and `StorageAddr` fields to options. - Implement `ProvideStorage` method to initialize storage based on `StorageType`. - Update `Run` method to initialize storage via `ProvideStorage`. - Remove `storage` parameter from the `New` function. - Adjust `New` function accordingly. - Update `go.mod` and `go.sum` to remove `fx` and related dependencies. - Delete unused `storages` module and its tests. - Move storage initialization logic into `cmd/server/server.go`. This refactoring removes the usage of the `go.uber.org/fx` dependency injection framework, simplifying the application startup process. Storage initialization is now handled within the server command and can be configured via command-line flags. This change streamlines the application and reduces unnecessary complexity. Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 21f6622 - Browse repository at this point
Copy the full SHA 21f6622View commit details -
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2a6ab15 - Browse repository at this point
Copy the full SHA 2a6ab15View commit details -
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c4c1928 - Browse repository at this point
Copy the full SHA c4c1928View commit details -
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7fa336d - Browse repository at this point
Copy the full SHA 7fa336dView commit details -
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d547783 - Browse repository at this point
Copy the full SHA d547783View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.