From 7eb86bdb0154a24a627c342c7bfcc95320155779 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Thu, 20 Nov 2025 12:40:50 +0000 Subject: [PATCH 1/2] autotools: Rename `build-aux` to `autotools-aux` This change improves separation from CMake build directories, which typically use the "build" prefix. Additionally, corresponding `.gitignore` entries have been refactored. --- .gitignore | 17 +++-------------- Makefile.am | 2 +- {build-aux => autotools-aux}/m4/bitcoin_secp.m4 | 0 configure.ac | 4 ++-- src/CMakeLists.txt | 2 +- 5 files changed, 7 insertions(+), 18 deletions(-) rename {build-aux => autotools-aux}/m4/bitcoin_secp.m4 (100%) diff --git a/.gitignore b/.gitignore index ce33a84adf..cae28210d8 100644 --- a/.gitignore +++ b/.gitignore @@ -45,20 +45,9 @@ coverage.*.html *.gcno *.gcov -build-aux/ar-lib -build-aux/config.guess -build-aux/config.sub -build-aux/depcomp -build-aux/install-sh -build-aux/ltmain.sh -build-aux/m4/libtool.m4 -build-aux/m4/lt~obsolete.m4 -build-aux/m4/ltoptions.m4 -build-aux/m4/ltsugar.m4 -build-aux/m4/ltversion.m4 -build-aux/missing -build-aux/compile -build-aux/test-driver +/autotools-aux/ +!/autotools-aux/m4/bitcoin_secp.m4 + libsecp256k1.pc ### CMake diff --git a/Makefile.am b/Makefile.am index dc798575e3..07d7a2ba7f 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -ACLOCAL_AMFLAGS = -I build-aux/m4 +ACLOCAL_AMFLAGS = -I autotools-aux/m4 # AM_CFLAGS will be automatically prepended to CFLAGS by Automake when compiling some foo # which does not have an explicit foo_CFLAGS variable set. diff --git a/build-aux/m4/bitcoin_secp.m4 b/autotools-aux/m4/bitcoin_secp.m4 similarity index 100% rename from build-aux/m4/bitcoin_secp.m4 rename to autotools-aux/m4/bitcoin_secp.m4 diff --git a/configure.ac b/configure.ac index 6028ee288d..36699c1799 100644 --- a/configure.ac +++ b/configure.ac @@ -19,8 +19,8 @@ define(_LIB_VERSION_AGE, 0) AC_INIT([libsecp256k1],m4_join([.], _PKG_VERSION_MAJOR, _PKG_VERSION_MINOR, _PKG_VERSION_PATCH)m4_if(_PKG_VERSION_IS_RELEASE, [true], [], [-dev]),[https://github.com/bitcoin-core/secp256k1/issues],[libsecp256k1],[https://github.com/bitcoin-core/secp256k1]) -AC_CONFIG_AUX_DIR([build-aux]) -AC_CONFIG_MACRO_DIR([build-aux/m4]) +AC_CONFIG_AUX_DIR([autotools-aux]) +AC_CONFIG_MACRO_DIR([autotools-aux/m4]) AC_CANONICAL_HOST # Require Automake 1.11.2 for AM_PROG_AR diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index ecbbbbe8e9..46db77809d 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -95,7 +95,7 @@ set_target_properties(secp256k1_objs PROPERTIES ) # This emulates Libtool to make sure Libtool and CMake agree on the ABI version, -# see below "Calculate the version variables" in build-aux/ltmain.sh. +# see below "Calculate the version variables" in autotools-aux/ltmain.sh. math(EXPR ${PROJECT_NAME}_soversion "${${PROJECT_NAME}_LIB_VERSION_CURRENT} - ${${PROJECT_NAME}_LIB_VERSION_AGE}") set_target_properties(secp256k1 PROPERTIES SOVERSION ${${PROJECT_NAME}_soversion} From 748c0fdd67c646c83bd62e74a8e205e04d314e07 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Thu, 20 Nov 2025 12:42:08 +0000 Subject: [PATCH 2/2] Add CMake build directory patterns to `.gitignore` --- .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index cae28210d8..fbc311d7b5 100644 --- a/.gitignore +++ b/.gitignore @@ -52,8 +52,8 @@ libsecp256k1.pc ### CMake /CMakeUserPresets.json -# Default CMake build directory. -/build +# CMake build directories. +/*build* ### Python __pycache__/