Check if variable=yes instead of if var is set in travis.sh #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichai
changed the title
|
I think that's an improvement but then we should do this for |
not-empty. Before this, setting `VALGRIND=wat` was considered as true, and to make it evaluate as false you had to unset the variable `VALGRIND=` but not it checks if `VALGRIND=yes` and if it's not `yes` then it's evaluated to false
|
Should we change the corresponding flags to |
|
We could, but unlike |
That was my thought. |
|
@elichai do you want to make that change? |
Sorry, forgot about this. pushed now. |
real-or-random
approved these changes
Sep 15, 2020
jonasnick
approved these changes
Sep 15, 2020
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 29, 2020
Summary: ``` Right now travis.sh checks if VALGRIND and CTIMETEST are set or not, but in travis.yml we explictly set them to yes so I think it's more intuitive to check if they're equal to yes such that setting CTIMETEST=no(or anything other than "yes") will disable the test. pointed out by @real-or-random here: #696 (comment) ``` Backport of secp256k1 [[bitcoin-core/secp256k1#782 | PR782]]. Includes the missing CTIMETEST variable for s390x. Depends on D7630. Test Plan: Run the Travis build. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7631
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Sep 30, 2020
Summary: ``` Right now travis.sh checks if VALGRIND and CTIMETEST are set or not, but in travis.yml we explictly set them to yes so I think it's more intuitive to check if they're equal to yes such that setting CTIMETEST=no(or anything other than "yes") will disable the test. pointed out by @real-or-random here: #696 (comment) ``` Backport of secp256k1 [[bitcoin-core/secp256k1#782 | PR782]]. Includes the missing CTIMETEST variable for s390x. Depends on D7630. Test Plan: Run the Travis build. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now travis.sh checks if
VALGRINDandCTIMETESTare set or not, but in travis.yml we explictly set them toyesso I think it's more intuitive to check if they're equal toyessuch that settingCTIMETEST=no(or anything other than "yes") will disable the test.pointed out by @real-or-random here: #696 (comment)