Commits on Jan 8, 2021

1. Ask brew for valgrind include path …

   Valgrind is typically installed using brew on macOS. This commit
   makes ./configure detect this case set the appropriate include
   directory (in the same way as we already do for openssl and gmp).

   

   real-or-random committed Jan 8, 2021
   1 Configuration menu

   • View commit details
   • Copy full SHA for 252c19d
   • Browse repository at this point

   Copy the full SHA

   252c19d View commit details

   Browse the repository at this point in the history

2. Restructure and tidy configure.ac …

   No behavioral changes.

   

   real-or-random committed Jan 8, 2021
   1 Configuration menu

   • View commit details
   • Copy full SHA for 47802a4
   • Browse repository at this point

   Copy the full SHA

   47802a4 View commit details

   Browse the repository at this point in the history

3. Improve CC_FOR_BUILD detection …

   This commits simply uses CC as CC_FOR_BUILD and the same for
   corresponding flags if we're not cross-compiling. This has a number of
   benefits in this common case:
    - It avoids strange cases where very old compilers are used (bitcoin-core#768).
    - Flags are consistently set for CC and CC_FOR_BUILD.
    - ./configure is faster.
    - You get compiler x consistently if you set CC=x; we got this wrong
      in CI in the past.
   
   ./configure warns if a _FOR_BUILD variable is set but ignored because
   we're not cross-compiling.
   
   The change exposed that //-style comments are used in gen_context.c,
   which is also fixed by this commit.
   
   This commit also reorganizes code in configure.ac to have a cleaner
   separation of sections.

   

   real-or-random committed Jan 8, 2021
   1 Configuration menu

   • View commit details
   • Copy full SHA for 3c15130
   • Browse repository at this point

   Copy the full SHA

   3c15130 View commit details

   Browse the repository at this point in the history