BIP 197: Hashed Time-Locked Collateral Contract #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjablack
changed the title
matthewjablack
changed the title
matthewjablack
changed the title
luke-jr
changed the title
|
Never self-assign BIP numbers. |
|
(BIP 200 is already reserved for something else) |
luke-jr
reviewed
Mar 28, 2019
luke-jr
reviewed
Mar 28, 2019
bip-0200.mediawiki
Outdated
| Comments-Summary: No comments yet. | ||
| Comments-URI: TBD | ||
| Status: Proposal | ||
| Type: Informational |
luke-jr
reviewed
Mar 28, 2019
bip-0200.mediawiki
Outdated
| Atomic Loans team <info@atomicloans.io> | ||
| Comments-Summary: No comments yet. | ||
| Comments-URI: TBD | ||
| Status: Proposal |
|
For a BIP number to be assigned, you must add a Backwards compatibility section. |
luke-jr
reviewed
Mar 28, 2019
This was referenced Mar 28, 2019
luke-jr
changed the title
|
Please use BIP number 197 (and purge the incorrect number from the git branch history) |
matthewjablack
force-pushed
the
htlcc
branch
8 times, most recently
from
5eeb2d1
to
4809519
Compare
luke-jr
reviewed
Mar 29, 2019
bip-0197.mediawiki
Outdated
| Title: Hashed Time-Locked Collateral Contract | ||
| Author: Matthew Black <matthew@atomicloans.io> | ||
| Tony Cai <tony@atomicloans.io> | ||
| Atomic Loans team <info@atomicloans.io> |
There was a problem hiding this comment.
Not sure teams can be authors; either way, this needs to match what's in README
There was a problem hiding this comment.
Removed Atomic Loans team <info@atomicloans.io> from Author list
luke-jr
reviewed
Mar 29, 2019
| <pre> | ||
| BIP: 197 | ||
| Layer: Applications | ||
| Title: Hashed Time-Locked Collateral Contract |
There was a problem hiding this comment.
Changed title in README for BIP 197 to Hashed Time-Locked Collateral Contract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
This proposal went through the mailing list: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-March/016805.html without any further discussion. Currently this proposal has been implemented by in the ChainAbstractionLayer (https://github.com/liquality/chainabstractionlayer/tree/dev). I would like to kindly ask for BIP # assignment and have this merged into upstream bips.
Cheers,
Matthew Black