Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double semicolon cleanup #7263

Merged
merged 1 commit into from Jan 4, 2016
Merged

Double semicolon cleanup #7263

merged 1 commit into from Jan 4, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2015

Assuming, and clarifying, the empty statements weren't intentional.

@paveljanik
Copy link
Contributor

Can you please remove also the rest?

qt/bantablemodel.cpp:    return columns.length();;
qt/guiutil.cpp:        QString msg(QUrl::toPercentEncoding(info.message));;
qt/peertablemodel.cpp:    return columns.length();;
test/rpc_tests.cpp:    BOOST_CHECK_NO_THROW(CallRPC(string("setban 127.0.0.0 remove")));;
test/rpc_tests.cpp:    BOOST_CHECK_NO_THROW(CallRPC(string("setban 127.0.0.0/24 remove")));;

@ghost
Copy link
Author

ghost commented Dec 30, 2015

PR updated accordingly. Why don't we spin off Qt!?

@maflcko
Copy link
Member

maflcko commented Dec 30, 2015

utACK a5a0831

@paveljanik
Copy link
Contributor

ACK a5a0831

@fanquake
Copy link
Member

@jonasschnelli
Copy link
Contributor

ACK a5a0831

@paveljanik
Copy link
Contributor

ACK a5a0831

@laanwj laanwj merged commit a5a0831 into bitcoin:master Jan 4, 2016
laanwj added a commit that referenced this pull request Jan 4, 2016
a5a0831 Double semicolon cleanup. (21E14)
codablock pushed a commit to codablock/dash that referenced this pull request Sep 5, 2017
a5a0831 Double semicolon cleanup. (21E14)
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Sep 7, 2017
* Merge pull request bitcoin#7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request bitcoin#7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request bitcoin#7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request bitcoin#7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request bitcoin#7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request bitcoin#7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge bitcoin#7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge bitcoin#7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge bitcoin#7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants