You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A couple ideas for this: we should change the assert_feerate macro to just a plain vanilla function - right now it's difficult to read and not very approachable. It should take in an optional descriptor string to calculate the satisfaction weight instead of assume the same P2WPKH_FAKE_WITNESS_SIZE for every psbt. We can add some legacy descriptors to wallet/tests/common.rs and then come up with a similar assert_feerate_legacy that contains logic specific to pre-segwit transactions.
This discussion came up on #1115.
Currently we are only testing segwit wallets:
bdk/crates/bdk/tests/common.rs
Lines 107 to 156 in f95506b
Do we want to support legacy wallets?
If yes, we need legacy wallet tests.
The text was updated successfully, but these errors were encountered: