Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up clippy allows #1186

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Clean up clippy allows #1186

merged 6 commits into from
Jan 31, 2024

Commits on Jan 31, 2024

  1. refactor: remove old clippy allow attributes 

    These lints either resolved themselves, or the code has changed such that
they no longer apply, hence they can be removed with no further changes.

`clippy::derivable_impls`
`clippy::needless_collect`
`clippy::almost_swapped`
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    64a9019 View commit details
    Browse the repository at this point in the history

  2. ref(example_cli): add typedefs to reduce type complexity 

    - Add typedefs to model the result of functions `planned_utxos`
and `init`

- Add new struct `CreateTxChange` to hold any change info
resulting from `create_tx`

These changes help resolve clippy::type_complexity
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    4679ca1 View commit details
    Browse the repository at this point in the history

  3. ref(psbt): refactor body of get_utxo_for to address `clippy::manual… 

    …_map`
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f11d663 View commit details
    Browse the repository at this point in the history

  4. ref(wallet): Wallet::preselect_utxos now accepts a &TxParams 

    to reduce the number of required function args in order to satisfy
`clippy::too_many_arguments`
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    097d818 View commit details
    Browse the repository at this point in the history

  5. ref(esplora): Box a large esplora_client::Error 

    to address `clippy::result_large_err`. Clippy's default large-error-
threshold is 128. `esplora_client::Error` currently has size 272.
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    89a7ddc View commit details
    Browse the repository at this point in the history

  6. ref(example_cli): Add new struct Init 

    for holding the items returned from `example_cli::init`
    @ValuedMammal
    ValuedMammal committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    1c15cb2 View commit details
    Browse the repository at this point in the history