ci: add test with MSRV 1.63.0 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
ci/test_msrv_163
branch
2 times, most recently
from
85c5a35
to
e9a1ba0
Compare
24 tasks
notmandatory
force-pushed
the
ci/test_msrv_163
branch
from
e9a1ba0
to
4b42108
Compare
|
@notmandatory I did another pass on this one, I think this would also be a good one to get into the next release, to keep the project in standard with the rest of the ecosystem, wdyt ? |
storopoli
reviewed
May 27, 2024
ValuedMammal
approved these changes
May 28, 2024
notmandatory
added a commit
that referenced
this pull request
Aug 6, 2024
4dd7e21 Bump version to 0.21.0 and update CHANGELOG.md (Steve Myers) Pull request description: Bumped crate version to 0.21.0 and added below to changelog: ## 0.21.0 - Add use-rustls-ring feature #135 - refactor: make validate_merkle_proof more efficient #134 - chore: set rust edition to 2021, fix clippy, add ci fmt and clippy checks #139 ## 0.20.0 - Upgrade rustls to 0.23 #132 - chore(deps): upgrade rust-bitcoin to 0.32.0 #133 - ci: add test with MSRV 1.63.0 #128 ACKs for top commit: oleonardolima: ACK 4dd7e21 ValuedMammal: ACK 4dd7e21 Tree-SHA512: 3fcec2fb437733eac235bccb1b9c8f6b706e7a713c71de85016adc93f7db128ca6eadb5e9d1d44df27f1b49cce139b222aa9c21343afcf25befdf80a47442e51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the main BDK crates are changing to MSRV 1.63.0 as is LDK the CI for this project should also have an MSRV and test against it in CI.
Also rustc 1.63 is the version shipped with the current debian stable (bookworm): https://packages.debian.org/stable/rust/rustc