fix typehints #182

JaskRendix · 2024-01-18T08:37:28Z

PR reduces the number of typehints 289>149

While fixing, by following a chain of typehints, I arrived to the source here:

class TiledMap(TiledElement):
    def __init__(
        self,
        filename: Optional[str] = None, <---------- here

is it correct an Optional?

apps/pygame_sdl2_demo.py

apps/pygame_demo.py

pytmx/pytmx.py

JaskRendix commented Jan 18, 2024

View reviewed changes

apps/pygame_sdl2_demo.py Outdated Show resolved Hide resolved

JaskRendix commented Jan 18, 2024

View reviewed changes

apps/pygame_demo.py Show resolved Hide resolved

JaskRendix commented Jan 18, 2024

View reviewed changes

pytmx/pytmx.py Show resolved Hide resolved

JaskRendix force-pushed the typehints branch from 6911994 to 0123514 Compare January 18, 2024 08:52

typehints

a78d7c8

JaskRendix force-pushed the typehints branch from 0123514 to a78d7c8 Compare January 19, 2024 18:23

JaskRendix marked this pull request as ready for review January 19, 2024 18:28

Merge branch 'bitcraft:master' into typehints

5c4b21d

JaskRendix force-pushed the typehints branch 6 times, most recently from 15849af to 320de11 Compare January 20, 2024 09:28

JaskRendix marked this pull request as draft January 20, 2024 11:58

JaskRendix force-pushed the typehints branch 4 times, most recently from 0745b18 to 1965ca6 Compare January 22, 2024 20:55

typehints

b8f6d69

JaskRendix force-pushed the typehints branch 3 times, most recently from 2c45582 to a41a47c Compare January 24, 2024 18:38

JaskRendix marked this pull request as ready for review February 18, 2024 19:54

typehints

d574e09

JaskRendix force-pushed the typehints branch from a41a47c to d574e09 Compare September 3, 2024 14:18

Provide feedback