Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database.Esqueleto.Experimental does not export SqlSelect #356

Open
parsonsmatt opened this issue Mar 23, 2023 · 2 comments
Open

Database.Esqueleto.Experimental does not export SqlSelect #356

parsonsmatt opened this issue Mar 23, 2023 · 2 comments

Comments

@parsonsmatt
Copy link
Collaborator

This may be an intentional omission, but it seems like we should export it - depending on an internal module just for that feels weird.

@belevy
Copy link
Collaborator

belevy commented May 28, 2023

SqlSelect is an internal implementation detail though. Is there a reason why we want to encourage its use directly? In fact, custom instances should be fairly rare in an ideal world and needing to import the Internal module signifies that you are relying on some internal behavior that is subject to change (i.e. with 4.0.0.0 that I am preparing right now)

@parsonsmatt
Copy link
Collaborator Author

I don't really think it's that much of an internal implementation detail - it shows up in the public API via select :: (SqlSelect a r) => SqlQuery a -> SqlPersistT m [r]. I've ended up importing or needing it in every work codebase I've ever done, especially if I'm doing anything more interesting or fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants