Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semantics of not_ applied over &&. and ||. #379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blujupiter32
Copy link

This PR fixes #359 by always wrapping arguments to not_ in parentheses when building SQL queries. Some tests combining not_ with &&. and ||. have also been added to Common.Test.

This is technically a breaking change: not_ (x &&. y) is no longer equivalent to (not_ x) &&. y, for example, although the equivalence is probably unintended.


Before submitting your PR, check that you've:

  • Bumped the version number.
  • Ran stylish-haskell and otherwise adhered to the style guide.
    • stylish-haskell fails to parse the DEPRECATED pragma for sub_select in Database.Esqueleto.Internal.Internal.

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not_ is broken
1 participant