Fix semantics of not_
applied over &&.
and ||.
#379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #359 by always wrapping arguments to
not_
in parentheses when building SQL queries. Some tests combiningnot_
with&&.
and||.
have also been added toCommon.Test
.This is technically a breaking change:
not_ (x &&. y)
is no longer equivalent to(not_ x) &&. y
, for example, although the equivalence is probably unintended.Before submitting your PR, check that you've:
stylish-haskell
and otherwise adhered to the style guide.stylish-haskell
fails to parse theDEPRECATED
pragma forsub_select
inDatabase.Esqueleto.Internal.Internal
.After submitting your PR: