Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixInvalidDayOffsetPreprocessor fails #181

Closed
sunkup opened this issue Oct 31, 2024 · 0 comments · Fixed by #182
Closed

FixInvalidDayOffsetPreprocessor fails #181

sunkup opened this issue Oct 31, 2024 · 0 comments · Fixed by #182
Assignees
Labels
bug Something isn't working

Comments

@sunkup
Copy link
Member

sunkup commented Oct 31, 2024

FixInvalidDayOffsetPreprocessor processes the whole ics file as a long string. The tests only run on a string containing the isolated DURATION property though, so they did not catch the inability to parse DURATION as a VALUE.

Reported in ICSx5: bitfireAT/icsx5#462

This works fine:

@Test
fun test_FixString_CompleteICalProperty() {
    fixAndAssert("DURATION:P1D", "DURATION:PT1D")
}

and this does not:

@Test
fun test_FixString_CompleteICalProperty() {
    fixAndAssert(
        "REFRESH-INTERVAL;VALUE=DURATION:P1D",
        "REFRESH-INTERVAL;VALUE=DURATION:PT1D"
    )
}
@sunkup sunkup added the bug Something isn't working label Oct 31, 2024
@sunkup sunkup self-assigned this Oct 31, 2024
@sunkup sunkup linked a pull request Oct 31, 2024 that will close this issue
@sunkup sunkup changed the title FixInvalidDayOffsetPreprocessor fails when applied to the whole iCal property string FixInvalidDayOffsetPreprocessor fails Nov 4, 2024
@sunkup sunkup moved this from Todo to In Progress in DAVx⁵ Releases Nov 4, 2024
@sunkup sunkup moved this from In Progress to In Review in DAVx⁵ Releases Nov 6, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant