Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] Add VirtualService support for istio #3216

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

thomasv314
Copy link
Contributor

Description of the change

Adds the ability for external DNS to pull information about Istio VirtualServices

Benefits

Supports functionality existing in the latest version of external-dns

Possible drawbacks

None

Applicable issues

None

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

Copy link
Contributor

@javsalgar javsalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

@javsalgar
Copy link
Contributor

Before merging, could you check that updating the cluster role does not break upgrades? I know that there are some immutable fields in some of the K8s objects. Could you confirm that this is not the case?

@thomasv314
Copy link
Contributor Author

hi @javsalgar, appreciate the quick review. I can confirm that the fields modified in this PR are mutable and does not break upgrades.

@javsalgar
Copy link
Contributor

Awesome, merging then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants