propper uncompressed keys handling #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The first byte of the public encoding indicates the format of the key: 0x04 for uncompressed, 0x03 and 0x02 for compressed. This could be used to determine the length that needs to be sliced. A test case for this would be useful. |
Contributor
Author
|
UPDATED @braydonf by test case you mean "unit test" or example? you can see example with issue to bitcore-lib |
Contributor
|
Yeah, a unit test at https://github.com/bitpay/bitcore-ecies/blob/master/test/ecies.js |
Contributor
Author
|
@bitjson something like that? |
Contributor
|
The new unit tests look great to me! But maybe you meant to ping @braydonf? :) |
test/ecies.js
Outdated
| var secret = 'test'; | ||
|
|
||
| // test uncompressed | ||
| var alicePrivateKey = new bitcore.PrivateKey.fromObject(new Buffer('1fa76f9c799ca3a51e2c7c901d3ba8e24f6d870beccf8df56faf30120b38f360', 'hex')); |
Contributor
There was a problem hiding this comment.
Instantiating the private key for compressed and uncompressed (line 139 and line 151 should be more clear with this:
var alicePrivateKey = new bitcore.PrivateKey.fromObject({
bn: '1fa76f9c799ca3a51e2c7c901d3ba8e24f6d870beccf8df56faf30120b38f360',
compressed: false,
network: 'livenet'
});
Contributor
|
@axet Thanks for the test case |
Contributor
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitpay/bitcore-lib#88
Maybe better to add additional check inside first try/catch for public get over rest of the data?