Allow user to specify versions map for mysql

pkg/apis/mysql/v1alpha1/mysqlcluster_types.go

@@ -43,13 +43,16 @@ type MysqlClusterSpec struct {
 	// +kubebuilder:validation:MaxLength=63
 	SecretName string `json:"secretName"`
 
-	// Represents the percona image tag.
+	// Represents the MySQL version that will be run. The available version can be found here:
+	// https://github.com/presslabs/mysql-operator/blob/0fd4641ce4f756a0aab9d31c8b1f1c44ee10fcb2/pkg/util/constants/constants.go#L87
+	// This field should be set even if the Image is set to let the operator know which mysql version is running.
+	// Based on this version the operator can take decisions which features can be used.
 	// Defaults to 5.7
 	// +optional
 	MysqlVersion string `json:"mysqlVersion,omitempty"`
 
 	// To specify the image that will be used for mysql server container.
-	// If this is specified then the mysqlVersion is ignored.
+	// If this is specified then the mysqlVersion is used as source for MySQL server version.
 	// +optional
 	Image string `json:"image,omitempty"`
 

pkg/internal/mysqlcluster/mysqlcluster.go

@@ -18,6 +18,7 @@ package mysqlcluster
 
 import (
 	"fmt"
+	"github.com/presslabs/mysql-operator/pkg/options"
 	"strings"
 
 	"github.com/blang/semver"
@@ -190,6 +191,12 @@ func (c *MysqlCluster) GetMysqlImage() string {
 		return c.Spec.Image
 	}
 
+	// check if the user set some overrides
+	opt := options.GetOptions()
+	if img, ok := opt.MySQLVersionImageOverride[c.GetMySQLSemVer().String()]; ok {
+		return img
+	}
+
 	if img, ok := constants.MysqlImageVersions[c.GetMySQLSemVer().String()]; ok {
 		return img
 	}
@@ -212,5 +219,5 @@ func (c *MysqlCluster) UpdateSpec() {
 func (c *MysqlCluster) ShouldHaveInitContainerForMysql() bool {
 	expectedRange := semver.MustParseRange(">=5.7.26 <8.0.0 || >=8.0.15")
 
-	return strings.HasPrefix(c.GetMysqlImage(), "percona") && expectedRange(c.GetMySQLSemVer())
+	return strings.Contains(c.GetMysqlImage(), "percona") && expectedRange(c.GetMySQLSemVer())
 }

pkg/options/options.go

@@ -65,6 +65,10 @@ type Options struct {
 
 	// Namespace where to look after objects. This will limit the operator action range.
 	Namespace string
+
+	// MySQLVersionImageOverride define a map between MySQL version and image.
+	// This overrides the default versions and has priority.
+	MySQLVersionImageOverride map[string]string
 }
 
 type pullpolicy corev1.PullPolicy
@@ -89,7 +93,7 @@ func newPullPolicyValue(defaultValue corev1.PullPolicy, v *corev1.PullPolicy) *p
 }
 
 const (
-	defaultExporterImage = "prom/mysqld-exporter:latest"
+	defaultExporterImage = "prom/mysqld-exporter:v0.11.0"
 
 	defaultImagePullPolicy     = corev1.PullIfNotPresent
 	defaultImagePullSecretName = ""
@@ -134,6 +138,9 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
 
 	fs.StringVar(&o.Namespace, "namespace", defaultNamespace,
 		"The namespace to restrict the client to watch objects.")
+
+	fs.StringToStringVar(&o.MySQLVersionImageOverride, "mysql-versions-to-image", map[string]string{},
+		"A map to override default image for different mysql versions.")
 }
 
 var instance *Options