Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default leader election ID #368

Closed
AMecea opened this issue Jul 9, 2019 · 0 comments
Closed

Change default leader election ID #368

AMecea opened this issue Jul 9, 2019 · 0 comments

Comments

@AMecea
Copy link
Contributor

AMecea commented Jul 9, 2019

By default, controller-runtime sets the election ID to default/controller-leader-election-helper which is common to all operators build with controller-runtime.

We should set the ID to something custom: mysql-operator-leader-election.

@AMecea AMecea closed this as completed in 34f9532 Jul 15, 2019
chapsuk pushed a commit to chapsuk/mysql-operator that referenced this issue Oct 16, 2023
* test: update vtorc test to not specify a config for vtorc

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: make vtorc compulsary by adding a default

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove repair replication code from the operator

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: augment test to also verify VTOrc fixes primary being read-only

Signed-off-by: Manan Gupta <manan@planetscale.com>

* docs: release notes changes

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant