[.5][1][happyconcepts][svk31] Missing Launcher Icon

[happyconcepts]

No icon is shown in the launcher. See lower left of screenshot.
Light client 180315 amd64 deb ...new install on ubuntu 16.04

[happyconcepts]

@wmbutler Can i take this small bug?

[happyconcepts]

Probably more like a job for @svk31 or @calvinfroedge

Icon=bitshares2-light in the .desktop file ...

[wmbutler]

@happyconcepts happy to give it to you if you like.

[happyconcepts]

Sure for 180401, thanks!

[happyconcepts]

So in my case (ubuntu):

1. The installer wrote bitshares2-light.png to this location:
   /usr/share/icons/hicolor/0x0/apps/bitshares2-light.png
   I could not locate other bitshares icons in the larger formats e.g. 256x256, 512x512

Can we confirm that this is the right installation location? hicolor is just one of several themes in ubuntu...

2. The .desktop specifies bitshares2-light.png but without the full filepath, apparently.

Workaround is to manually edit the .desktop to:
Icon=/usr/share/icons/hicolor/0x0/apps/bitshares2-light.png

Ideas to make it happen in the build?

[wmbutler]

Hotfix @svk31 this is a pretty major oversight.

[happyconcepts]

might help ....
electron-userland/electron-builder#2269 (comment)

but it feels like a missing dependency may be preventing my install from generating the icons locally.

[svk31]

That was less complicated than it seemed: the icon.png image was being placed in a 0x0 icon folder which is not indexed by linux, so the icon was not found. And since there was an icon.png included, electron-builder did not auto-generate the proper icons from the Mac icon.icns file.

Simply deleting the icon.png file fixed the issue in the end after lots of digging..

[happyconcepts]

@wmbutler how much longer should I wait on this? Thanks.

[happyconcepts]

@wmbutler can this be paid please or did you already pay @svk31?

[wmbutler]

https://wallet.bitshares.org/#/account/sell-bitcoin