Skip to content

Conversation

@theMickster
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26935

📔 Objective

Ready to go full throttle with Claude code reviews using our reusable workflow.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@theMickster theMickster requested a review from a team October 22, 2025 09:09
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details5d615a13-0781-4af9-827c-a13770442cbc

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.37%. Comparing base (d553d37) to head (fc81b6e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files         291      291           
  Lines       29391    29391           
=======================================
  Hits        23034    23034           
  Misses       6357     6357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theMickster theMickster marked this pull request as ready for review October 22, 2025 16:48
@theMickster theMickster requested a review from a team as a code owner October 22, 2025 16:48
@coroiu coroiu requested a review from Copilot October 23, 2025 12:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the code review workflow to use a centralized, reusable workflow from the gh-actions repository, simplifying maintenance and standardization across Bitwarden repositories.

Key Changes:

  • Migrated from inline workflow definition to reusable workflow pattern
  • Extracted review prompt to separate markdown file for better maintainability
  • Added ready_for_review trigger to the workflow

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/review-code.yml Replaced custom workflow implementation with call to centralized reusable workflow, passing Azure secrets and permissions
.claude/prompts/review-code.md Created new file containing the Claude code review prompt instructions previously embedded in the workflow

coroiu
coroiu previously approved these changes Oct 23, 2025
@coroiu coroiu dismissed their stale review October 23, 2025 12:16

Hang on, I have some questions

@theMickster theMickster requested a review from coroiu October 24, 2025 05:35
@theMickster theMickster merged commit 13f4c42 into main Oct 24, 2025
54 of 55 checks passed
@theMickster theMickster deleted the arch/pm-26935/reusable-code-review-workflow branch October 24, 2025 07:19
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants