From 820d5684c77ec57c83433fb7733ea25681789148 Mon Sep 17 00:00:00 2001 From: John Richard Chipps-Harding Date: Thu, 6 Aug 2020 00:40:31 +0100 Subject: [PATCH 1/2] Silence Progress Events --- README.md | 1 + src/Scene.js | 13 ++++++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index fd25a26..6fca59b 100644 --- a/README.md +++ b/README.md @@ -87,6 +87,7 @@ classToggle | string or string[2] | yes | undefined | [link](http://scrollmagic. pin | boolean or string | yes | undefined | [link](http://scrollmagic.io/docs/ScrollMagic.Scene.html#setPin) pinSettings | PinSettings | yes | undefined | See Types and [link](http://scrollmagic.io/docs/ScrollMagic.Scene.html#setPin) enabled | boolean | yes | true | Can be changed on-the-fly +progressEvents | boolean | yes | true | Ability to silence progress events reducing redraws ## Types diff --git a/src/Scene.js b/src/Scene.js index b5418bd..e86910d 100644 --- a/src/Scene.js +++ b/src/Scene.js @@ -22,6 +22,7 @@ export type SceneProps = { loglevel?: number, indicators?: boolean, enabled?: boolean, + progressEvents?: boolean, /* setClassToggle */ classToggle?: string | Array, @@ -197,7 +198,7 @@ class SceneBase extends React.PureComponent { } initEventHandlers() { - let { children } = this.props; + let { children, progressEvents = true } = this.props; if (typeof children !== 'function' && !isGSAP(callChildFunction(children, 0, 'init'))) { return; @@ -209,11 +210,13 @@ class SceneBase extends React.PureComponent { }); }); - this.scene.on('progress', (event) => { - this.setState({ - progress: event.progress + if(progressEvents){ + this.scene.on('progress', (event) => { + this.setState({ + progress: event.progress + }); }); - }); + } } render() { From 9ffd15a488dcdf8ef39518a5501cf8528c4b11fa Mon Sep 17 00:00:00 2001 From: John Richard Chipps-Harding Date: Thu, 6 Aug 2020 01:18:42 +0100 Subject: [PATCH 2/2] Update types --- src/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/index.d.ts b/src/index.d.ts index c4143b0..b4a8e43 100644 --- a/src/index.d.ts +++ b/src/index.d.ts @@ -34,6 +34,7 @@ declare module 'react-scrollmagic' { loglevel?: number, indicators?: boolean, enabled?: boolean, + progressEvents?: boolean, /* setClassToggle */ classToggle?: string | string[],