Disable redefining __GLASSGOW_HASKELL__ to fix compatibility with Happy 2.0.x #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Int# and Int32# in happy
bramvdbogaerde
force-pushed
the
fix-happy
branch
from
f902bb5 to
58f62c9
Compare
|
Hi, I've also hit this and can confirm it fixes the issue. |
|
I can confirm that this fixes it for me when building for Arch. The hack was added for #41 but I think it's not a problem now - with this PR I could build it within one minute on GHC 9.2.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #77.
NOTE: I would like to remove the redefine entirely but since I am not sure what it's initial purpose was I only disable it for versions above GHC 9.1 which coincidentally correspond to the versions that do not perform an explicit type conversion from Int32# to Int#.