New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: clean-up packet parsing #25

Merged

blackbeam merged 1 commit into blackbeam:master from yjh0502:refactor-stream

May 14, 2018

Contributor

yjh0502 commented May 13, 2018

This PR introduces parse_packet to cleanup packet parsing in Stream. The PR actually fixes several problems/bugs.

EOF handling: AyncRead returns Ready(0) on EOF, but Stream didn't handle it correctly [1]. The PR handles the problem.
Ensure that exact amount of data is fed into PacketParser. It seems that PacketParser required to receive exact amount of data returned by PacketParser::parse.

The PR solves problems I observed while using the library.

[1] https://github.com/blackbeam/mysql_async/blob/master/src/io/mod.rs#L298


          stream: clean-up packet parsing

33fd66b

blackbeam merged commit a8a1503 into blackbeam:master

Owner

blackbeam commented May 14, 2018

Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet