-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustls: features guide backend #304
Conversation
as an aside, rust features are supposed to be additive, this is not currently the case with rustls/native-tls features. If both features are enabled the compile fails. Would you be interested in having changes made to rectify that? I think the fix would be to have each crypto backend use a different Opts (ie, ssl_opts would be ssl_opts_native & ssl_opts_rustls). Could get more complicated with traits, but doesn't seem necessary |
Completed as part of #313 |
@westy92 that PR doesn't include adding ring/aws-lc-rs features now that rustls made their crypto backend configurable. Setting |
I'd love the feature flag to have rustls with ring as an option. I was getting build errors in CI with the latest version because of the missing dependencies required for aws-lc-rs and had to revert to 0.34.1 |
buf-setup-action deprecated in favor of buf-action mysql_async held back from breaking minor version upgrade, they need to address blackbeam/mysql_async#304
buf-setup-action deprecated in favor of buf-action mysql_async held back from breaking minor version upgrade, they need to address blackbeam/mysql_async#304
@blackbeam ping in case this has flown under your radar |
6f936dc
to
3e8868f
Compare
rustls replaced ring with aws-lc-rs as default crypto backend, expose features to select between the two, along with a feature on whether to enable tls 1.2
0d62e1c
to
1c47a9f
Compare
rustls replaced ring with aws-lc-rs as default crypto backend,
expose features to select between the two, along with a feature on whether to enable tls 1.2