-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s/logprob/logdensity #427
s/logprob/logdensity #427
Conversation
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
- Coverage 89.99% 89.98% -0.01%
==========================================
Files 47 47
Lines 2189 2187 -2
==========================================
- Hits 1970 1968 -2
Misses 219 219
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bbb1f5c
to
7f13806
Compare
It looks like the documentation was built ok. Can you do one last check before we merge this? |
Went through all the examples - This is good to go. |
The library currently uses `logprob` to designate the target model's joint log-density. We adopt the mathematical terminology instead and replace `logprob` with `logdensity`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Will merge automatically when the tests pass.
Renaming logprob to logdensity for more consistent terminology.
How: search for
logprob(?!ability)
and replace withlogdensity
, excluding everything indocs/**
,examples/
,tests/**
as they are mostly logprob.Thank you for opening a PR!
A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.