Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit SCAN event on finish #1761

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Emit SCAN event on finish #1761

merged 4 commits into from
Sep 23, 2024

Conversation

TheTechromancer
Copy link
Collaborator

This PR adds some fields to the SCAN event:

  • started_at
  • finished_at
  • status
  • duration
  • duration_seconds

Also, an additional SCAN event is now emitted at the end of the scan. This acts as proof that the scan finished, and will be useful in the up-and-coming BBOT server.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 96.03175% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (4a06dc9) to head (c58cf71).
Report is 41 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/scanner/scanner.py 92% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #1761    +/-   ##
======================================
- Coverage     93%     93%    -0%     
======================================
  Files        344     346     +2     
  Lines      26507   26712   +205     
======================================
+ Hits       24440   24625   +185     
- Misses      2067    2087    +20     
Flag Coverage Δ
93% <97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer marked this pull request as ready for review September 21, 2024 17:25
@TheTechromancer TheTechromancer merged commit 8a3916d into dev Sep 23, 2024
8 checks passed
@TheTechromancer TheTechromancer deleted the scan-finish-event branch September 23, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants