Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loader works on node 18.20 #8

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: loader works on node 18.20 #8

merged 1 commit into from
Sep 19, 2024

Conversation

acutmore
Copy link
Collaborator

@acutmore acutmore commented Sep 19, 2024 •
edited by tchetwin
Loading

Node 18 does not support import.meta.filename this PR fixes this to use import.meta.url. Still needs node 18.20, rather than 18.18 for the register hook to be available.

@acutmore
fix: loader works on node 18.20
34b9185 
Signed-off-by: Ashley Claymore <aclaymore@bloomberg.net>
@acutmore acutmore requested a review from tchetwin September 19, 2024 09:16
@acutmore acutmore merged commit 0920b23 into main Sep 19, 2024
2 checks passed
@acutmore acutmore deleted the node-18-support branch September 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchetwin tchetwin tchetwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acutmore @tchetwin