fix(op): Base Goerli op-reth sync patches
#824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
force-pushed
the
cl/op-exec-patches
branch
from
fb0a825
to
e96862c
Compare
rakita
reviewed
Oct 23, 2023
rakita
reviewed
Oct 23, 2023
rakita
reviewed
Oct 23, 2023
| self.preverify_transaction() | ||
| .and_then(|()| self.transact_preverified()) | ||
| } | ||
| fn transact(&mut self) -> EVMResult<DBError>; |
There was a problem hiding this comment.
Should stay as this and logic should be changes for used function.
rakita
reviewed
Oct 23, 2023
crates/revm/src/evm_impl.rs
Outdated
| { | ||
| crate::handler::optimism::default_transact(self) | ||
| } | ||
| } |
There was a problem hiding this comment.
This should not go here, but inside transact_preverified logic will be skipped otherwise.
|
@clabby if you are okay with it, to speed things up i can create the PR on this branch |
refactor optimism: main_return
Co-authored-by: rakita <rakita@users.noreply.github.com>
chore: Introduce end handle
|
failed test unrelated to PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Contains several fixes for the Optimism state transition code.
Context
After hooking up the OP execution changes to
op-rethand performing a sync test on the Base Goerli network, a few bugs were found.Patches
mintvalue should be persisted to the sender account's balance to prevent loss of funds, and the sender's nonce should be bumped as well.transactfunction in theTransacttrait, and define a catch-all failure handler that persists themintvalue to and bumps the nonce of the caller account before returning a specialHaltvariant.Halts, a few special rules apply. These happen to be identical to the logic in the above catch-all.Halt::FailedDepositstatus.Reference Branch (cherry-picked #781 onto
3.5.0for integrating w/op-reth: https://github.com/anton-rs/op-revm/tree/cl/patch-op)