Ensure that cache monitor is shut down when appender is stopped #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoriceau
approved these changes
Mar 4, 2024
|
@bluedenim Any chance that you could take a look at this PR this weekend? Let me know if you need anything else from me to get this over the finish line. Thanks! |
|
Hello. Definitely. I've been swamped with work this week but will take a look tomorrow.
|
bluedenim
approved these changes
Mar 10, 2024
| @@ -284,6 +281,10 @@ public boolean stop() { | |||
| } | |||
| } | |||
|
|
|||
| if (null != cacheMonitor) { | |||
There was a problem hiding this comment.
👍
Actually this is probably a better place to do this even without the bug since the instance cleaning up its cacheMonitor is an implementation detail that shutDown should not care about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bluedenim Found one more leak after integrating the previous fix. The
TimePeriodBasedBufferMonitoralso creates an executor service that is not properly being shut down when the dynamically allocated appender is stopped. Simple fix is to move the shutdown call to the cache monitor into the same extracted method in the previous PR. The good news here is that the previous fix did address the leak of theLoggingEventCache-publish-thread. Now, we see a leak of theTimePeriodBasedBufferMonitor-publish-trigger, which this fix should address.