Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: services: helper: Add root page #3012

Merged
merged 1 commit into from
Nov 26, 2024
Merged

core: services: helper: Add root page #3012

merged 1 commit into from
Nov 26, 2024

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Nov 25, 2024 •
edited
Loading

Fix #2143

image

joaoantoniocardoso
joaoantoniocardoso reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a from fastapi.responses import HTMLResponse

@patrickelectric
core: services: helper: Add root page
f390ecf 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@joaoantoniocardoso joaoantoniocardoso merged commit a77382f into bluerobotics:master Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

@Williangalvani Williangalvani Awaiting requested review from Williangalvani

@JoaoMario109 JoaoMario109 Awaiting requested review from JoaoMario109

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helper service not showing on the list of available services
2 participants
@patrickelectric @joaoantoniocardoso