Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system libvips instead of pre-built one. #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mounirlamouri
Copy link

Installs vips-dev to the image so sharp can use it. The change also installs a few dependencies requires for sharp to build the C++ files required.

The version of alpine was upgraded from 18 to 19 because the minimum libvips required by sharp wasn't satisfied by alpine-18.

Finally, in addition to copying /apps, we are now also copying /lib and /usr/lib because libvips and some other dependencies are now needed. An alternative would be to list all the files needed but it would be tedious to maintain.

This change improves portability and security as pds is no longer depending on code built by a library but instead depends on the alpine package. An immediate benefit is that the alpine package doesn't use SSE4.2 instructions, allowing pds to run on older CPU like some Intel Atom processors.

Fixes #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pds implicitly requires sse4.2
1 participant