Convert from BaseModel to static jsonschema + TypedDict
#341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
337-add-basemodel-support
branch
from
73a8dff to
56b88ef
Compare
evalott100
force-pushed
the
337-add-basemodel-support
branch
from
56b88ef to
5f1d747
Compare
coretl
reviewed
Dec 18, 2024
evalott100
force-pushed
the
337-add-basemodel-support
branch
from
3c618ec to
fda7e64
Compare
evalott100
force-pushed
the
337-add-basemodel-support
branch
2 times, most recently
from
59a86e9 to
fdf2837
Compare
evalott100
force-pushed
the
337-add-basemodel-support
branch
from
fdf2837 to
3e827a2
Compare
evalott100
force-pushed
the
337-add-basemodel-support
branch
from
315bf60 to
35645e1
Compare
coretl
reviewed
Dec 20, 2024
Comment on lines
-20
to
-44
| DocumentType = Union[ | ||
| Type[Datum], | ||
| Type[DatumPage], | ||
| Type[Event], | ||
| Type[EventDescriptor], | ||
| Type[EventPage], | ||
| Type[Resource], | ||
| Type[RunStart], | ||
| Type[RunStop], | ||
| Type[StreamDatum], | ||
| Type[StreamResource], | ||
| ] | ||
|
|
||
| ALL_DOCUMENTS: Tuple[DocumentType, ...] = ( | ||
| Datum, | ||
| DatumPage, | ||
| Event, | ||
| EventDescriptor, | ||
| EventPage, | ||
| Resource, | ||
| RunStart, | ||
| RunStop, | ||
| StreamDatum, | ||
| StreamResource, | ||
| ) |
There was a problem hiding this comment.
I think this file probably has to go back to how it was, at least for the presence of DocumentType and ALL_DOCUMENTS
Comment on lines
+13
to
+21
| "anyOf": [ | ||
| { | ||
| "type": "object" | ||
| }, | ||
| { | ||
| "type": "null" | ||
| } | ||
| ], | ||
| "default": null |
There was a problem hiding this comment.
Hmm, this is actually saying that downstream clients now need to cope with the presence of this key, and its value being nul...
Comment on lines
-135
to
-143
| data_keys: NotRequired[ | ||
| Annotated[ | ||
| Dict[str, DataKey], | ||
| Field( | ||
| description="This describes the data stored alongside it in this " | ||
| "configuration object." | ||
| ), | ||
| ] | ||
| ] |
There was a problem hiding this comment.
...it used to be NotRequired[Dict]...
| class Configuration(BaseModel): | ||
| model_config = ConfigDict(extra="forbid") | ||
| data: Annotated[ | ||
| Union[Dict[str, Any], None], |
There was a problem hiding this comment.
...and now it's Union[Dict, None].
Is there any way to persuade pydantic to treat None as NotRequired in the JSON schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337