Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #147: SUNDIALS_BLAS_LAPACK not present in sundials 6 #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stuart-nolan
Copy link

Tested with scikits.odes 2.7.0 (at commit 57466a9), python 3.11.4, and sundials 6.6.1 compiled against oneMKL 2023.0 Update 2 on Ubuntu 22.04.3 LTS. The test details below were taken from this comment in #97:

Testing code and output w/ and w/o lapack

With lapack

import numpy as np
from scikits.odes.odeint import odeint

tout = np.linspace(0, 1)
initial_values = np.array([1])

def right_hand_side(t, y, ydot):
    ydot[0] = y[0]

output = odeint(right_hand_side, tout, initial_values,linsolver='lapackdense')
print(output.values.y)

In a bash shell

export MKL_VERBOSE=1
ipython
<run code above>
MKL_VERBOSE oneMKL 2023.0 Update 2 Product build 20230613 for Intel(R) 64 architecture Intel(R) Advanced Vector Extensions 2 (Intel(R) AVX2) enabled processors, Lnx 1.90GHz lp64 gnu_thread
MKL_VERBOSE SDOT(2,0x562640d4f1a0,1,0x562640d4f1a0,1) 1.89ms CNR:OFF Dyn:1 FastMM:1 TID:0  NThr:2
... <lots of redacted MKL_VERBOSE and output.values.y output>
[2.66339741]
 [2.7183115 ]]

With out lapack

import numpy as np
from scikits.odes.odeint import odeint

tout = np.linspace(0, 1)
initial_values = np.array([1])

def right_hand_side(t, y, ydot):
    ydot[0] = y[0]

output = odeint(right_hand_side, tout, initial_values,linsolver='dense')
print(output.values.y)

same bash shell/ipython session as above with lapack

... <lots of redacted output.values.y output and no MKL_VERBOSE output>
[2.66339741]
 [2.7183115 ]]

@aragilar
Copy link
Collaborator

@stuart-nolan Can you see if the new refactor has solved your issue?

@stuart-nolan
Copy link
Author

No.

Looks like this PR needs to be updated and applied for scikits.odes 3.0. I'll do that but I may not get to it quickly.

Signed-off-by: stuart-nolan <61199416+stuart-nolan@users.noreply.github.com>
@stuart-nolan
Copy link
Author

I'm not sure if you plan to merge this. No worries if you don't as interest in this capability seems low and I'm not using it.

Tested with scikits-odes v3.0.0, python 3.11.4, sundials 6.6.1, oneMKL 2024.2, on Ubuntu 22.04.4 LTS.

At some point in the coming months I'll upgrade to python 3.12.x and possibly sundials 7.x.x and test if this still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants