Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]fix the reorg routine stuck issue #191

Merged
merged 1 commit into from
May 7, 2021
Merged

[R4R]fix the reorg routine stuck issue #191

merged 1 commit into from
May 7, 2021

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented May 7, 2021

Description

There is a dead lock issue in the Reorg routine of Transaction Pool implement of v1.0.7, which is already fixed in the latest geth v1.10.2 version. The randomly ungraceful shutdown connection between the upgrade version and current version trigger the deadlock, it is rarely happen . Why the connection is ungraceful shutdown is not very clear(connection upgraceful shutdown is very common actually), but we obviously need tolerate this.

Rationale

https://github.com/ethereum/go-ethereum/blob/d8ff53dfb8a516f47db37dbc7fd7ad18a1e8a125/eth/protocols/eth/broadcast.go#L122

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@unclezoro unclezoro merged commit 8362792 into master May 7, 2021
@unclezoro unclezoro deleted the stuck_issue branch May 10, 2021 16:39
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
…ation

params: interopTime configuration and override option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants