Maven lifecycle participation fix #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collection of packaging goals is a set. Handle war goal as no classification. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Only alter jar plugin executions for jar packaging. Only alter war executions for war packaging. Don't remove execution if one of the executions goals matches. First we remove the goals and if no goals are left, we remove the execution. Signed-off-by: BJ Hargrave <bj@hargrave.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to the bnd-maven-plugin life cycle participant to more carefully replace goals.
Only alter jar plugin executions for jar packaging. Only alter war
executions for war packaging.
Don't remove execution if one of the executions goals matches.
First we remove the goals and if no goals are left, we remove the
execution.