From a4436bab7b83e311f8a4207b9c6d97acde4735ff Mon Sep 17 00:00:00 2001 From: Timothy J Fontaine Date: Sat, 15 Feb 2014 19:24:42 -0800 Subject: [PATCH] dgram: pass the bytes sent to the send callback Fixes #6953 --- lib/dgram.js | 2 +- test/simple/test-dgram-bytes-length.js | 31 ++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 test/simple/test-dgram-bytes-length.js diff --git a/lib/dgram.js b/lib/dgram.js index f31fd7158cfa1a..3a44707e03e354 100644 --- a/lib/dgram.js +++ b/lib/dgram.js @@ -319,7 +319,7 @@ Socket.prototype.send = function(buffer, function afterSend(err) { - this.callback(err ? errnoException(err, 'send') : null); + this.callback(err ? errnoException(err, 'send') : null, this.buffer.length); } diff --git a/test/simple/test-dgram-bytes-length.js b/test/simple/test-dgram-bytes-length.js new file mode 100644 index 00000000000000..4e90f78c809b6f --- /dev/null +++ b/test/simple/test-dgram-bytes-length.js @@ -0,0 +1,31 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); +var dgram = require('dgram'); + +var message = new Buffer('Some bytes'); +var client = dgram.createSocket('udp4'); +client.send(message, 0, message.length, 41234, "localhost", function(err, bytes) { + assert.strictEqual(bytes, message.length); + client.close(); +});