From bb33c28e2141a1eabdff753e6717f5aea5866146 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sat, 18 Jun 2016 01:39:00 +0200 Subject: [PATCH] tools: disable readability/function cpplint rule cpplint gets too easily confused by C++ constructs that look like function declarations but aren't. Furthermore, it's arguably a bad rule that conflicts with gcc's -Wunused-parameter flag. PR-URL: https://github.com/nodejs/node/pull/7334 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Trevor Norris --- tools/cpplint.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/cpplint.py b/tools/cpplint.py index a66c1cb193ac47..4f4af6fe337590 100644 --- a/tools/cpplint.py +++ b/tools/cpplint.py @@ -215,7 +215,11 @@ # flag. By default all errors are on, so only add here categories that should be # off by default (i.e., categories that must be enabled by the --filter= flags). # All entries here should start with a '-' or '+', as in the --filter= flag. -_DEFAULT_FILTERS = [ '-build/include_alpha', '-legal/copyright' ] +_DEFAULT_FILTERS = [ + '-build/include_alpha', + '-legal/copyright', + '-readability/function', + ] # We used to check for high-bit characters, but after much discussion we # decided those were OK, as long as they were in UTF-8 and didn't represent