Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<f32> for JsValue #1989

Closed
lastmjs opened this issue Mar 30, 2022 · 0 comments
Closed

Implement From<f32> for JsValue #1989

lastmjs opened this issue Mar 30, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone
v0.15.0

Comments

@lastmjs
Copy link
Contributor

lastmjs commented Mar 30, 2022

I've noticed that the From trait for f32, i128, i16, i8, u128, u16, and u8 are not implemented for JsValue. This is my first time contributing directly to boa, and so I'm just fixing something small that I think is a problem. This is all in preparation for #1975
This was referenced Mar 30, 2022
Closed
Closed
@bors bors bot closed this as completed in 6baf455 Apr 2, 2022
@raskad raskad added this to the v0.15.0 milestone Apr 3, 2022
@raskad raskad added the enhancement New feature or request label Apr 3, 2022
Razican pushed a commit that referenced this issue Jun 8, 2022
@lastmjs @Razican
Add From<f32> for JsValue (#1990)
b1e4e3e 
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel neccesary.
--->

This Pull Request fixes/closes #1989.

It changes the following:

- Implements From<f32> for JsValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Add From<f32> for JsValue demergent-labs/boa
2 participants
@lastmjs @raskad