Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map.prototype[@@iterator]() method not implemented #810

Closed
croraf opened this issue Oct 7, 2020 · 0 comments · Fixed by #847
Closed

Map.prototype[@@iterator]() method not implemented #810

croraf opened this issue Oct 7, 2020 · 0 comments · Fixed by #847
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request

Comments

@croraf
Copy link
Contributor

croraf commented Oct 7, 2020 •
edited
Loading

ECMASCript feature
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/@@iterator

Example code

let first = new Map([["1", "one"], ["2", "two"]]);
first[Symbol.iterator]

Context

This is blocking proper fix of #793
After this is done the merge() test should be unignored from boa/src/builtins/map/tests.rs
@croraf croraf added the enhancement New feature or request label Oct 7, 2020
@croraf croraf mentioned this issue Oct 7, 2020
Merged
@HalidOdat HalidOdat added the builtins PRs and Issues related to builtins/intrinsics label Oct 9, 2020
@croraf croraf mentioned this issue Oct 13, 2020
Merged
@HalidOdat HalidOdat linked a pull request Oct 13, 2020 that will close this issue
[builtin Map] Map.prototype.entries method and map iterator #847
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[builtin Map] Map.prototype.entries method and map iterator croraf/boa
2 participants
@HalidOdat @croraf