Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatementList: Rename statements to items #1014

Merged
merged 2 commits into from
Dec 31, 2020

Conversation

AnnikaCodes
Copy link
Contributor

This Pull Request fixes/closes #842

It changes the following:

  • Renames the statements property of the StatementList struct to items
  • Renames the StatementList::statements() function to StatementList::items()

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #1014 (26a4762) into master (a068ef2) will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   59.83%   59.79%   -0.05%     
==========================================
  Files         167      167              
  Lines       11018    11087      +69     
==========================================
+ Hits         6593     6629      +36     
- Misses       4425     4458      +33     
Impacted Files Coverage Δ
...ax/ast/node/declaration/async_function_decl/mod.rs 22.22% <0.00%> (ø)
...ax/ast/node/declaration/async_function_expr/mod.rs 24.00% <0.00%> (ø)
boa/src/syntax/ast/node/statement_list/mod.rs 48.71% <83.33%> (ø)
boa/src/syntax/ast/node/block/mod.rs 56.66% <100.00%> (ø)
...ax/ast/node/declaration/arrow_function_decl/mod.rs 60.86% <100.00%> (ø)
...c/syntax/ast/node/declaration/function_decl/mod.rs 68.42% <100.00%> (ø)
...c/syntax/ast/node/declaration/function_expr/mod.rs 61.29% <100.00%> (ø)
boa/src/syntax/ast/node/switch/mod.rs 61.42% <100.00%> (ø)
boa/src/syntax/parser/expression/assignment/mod.rs 50.58% <0.00%> (-12.95%) ⬇️
boa/src/syntax/parser/expression/mod.rs 81.89% <0.00%> (-10.65%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a068ef2...26a4762. Read the comment docs.

@AnnikaCodes
Copy link
Contributor Author

The Clippy failures are unrelated to this change; #1015 addresses them.

@HalidOdat HalidOdat added this to the v0.11.0 milestone Dec 31, 2020
@HalidOdat HalidOdat merged commit fd5c606 into boa-dev:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terminology - replace "statements" property in StatementList struct with "statement_list_items"
2 participants