Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spread in new and call expressions #1021

Merged
merged 4 commits into from
Jan 1, 2021
Merged

Fix spread in new and call expressions #1021

merged 4 commits into from
Jan 1, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 1, 2021

This Pull Request fixes spread in new and call expressions:

It changes the following:

  • Execution of new and call expressions so that it can use an iterable in spread

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1021 (c267871) into master (3b83767) will increase coverage by 0.04%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   60.10%   60.14%   +0.04%     
==========================================
  Files         167      167              
  Lines       11142    11156      +14     
==========================================
+ Hits         6697     6710      +13     
- Misses       4445     4446       +1     
Impacted Files Coverage Δ
boa/src/syntax/ast/node/spread/mod.rs 80.00% <ø> (ø)
boa_tester/src/read.rs 0.00% <ø> (ø)
boa/src/syntax/ast/node/call/mod.rs 84.09% <75.00%> (-3.09%) ⬇️
boa/src/syntax/ast/node/new/mod.rs 78.57% <80.00%> (-0.38%) ⬇️
boa/src/object/gcobject.rs 66.89% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b83767...7e91a23. Read the comment docs.

@Razican Razican added this to the v0.11.0 milestone Jan 1, 2021
@Razican Razican added bug Something isn't working execution Issues or PRs related to code execution labels Jan 1, 2021
@Razican
Copy link
Member

Razican commented Jan 1, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 20,882 20,936 +54
Ignored 15,585 15,585 0
Failed 42,026 41,972 -54
Panics 388 364 -24
Conformance 26.60 26.67 +0.07%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good :)

@RageKnify RageKnify merged commit a77c879 into boa-dev:master Jan 1, 2021
@tofpie tofpie deleted the fix-spread branch January 1, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants