-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog v0.11 #1052
Changelog v0.11 #1052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1052 +/- ##
==========================================
+ Coverage 58.37% 58.69% +0.32%
==========================================
Files 173 176 +3
Lines 12050 12389 +339
==========================================
+ Hits 7034 7272 +238
- Misses 5016 5117 +101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things I think can be improved.
Thanks @RageKnify, merged |
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposals for the PRs that aren't mentioned, my classifications (feature vs bug vs internal) might be wrong though.
There are 3 more PRs ready to be merged that along with #997 we should add at least some of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I found a couple of things that could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comments already made looks good to me :)
Co-authored-by: Iban Eguia <iban.eguia@cern.ch>
Co-authored-by: Iban Eguia <iban.eguia@cern.ch>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Changelog for v0.11