Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog v0.11 #1052

Merged
merged 15 commits into from
Jan 14, 2021
Merged

Changelog v0.11 #1052

merged 15 commits into from
Jan 14, 2021

Conversation

jasonwilliams
Copy link
Member

Changelog for v0.11

@codecov
Copy link

codecov bot commented Jan 9, 2021

Codecov Report

Merging #1052 (12519ac) into master (abd893c) will increase coverage by 0.32%.
The diff coverage is 68.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   58.37%   58.69%   +0.32%     
==========================================
  Files         173      176       +3     
  Lines       12050    12389     +339     
==========================================
+ Hits         7034     7272     +238     
- Misses       5016     5117     +101     
Impacted Files Coverage Δ
boa/src/builtins/function/mod.rs 69.64% <0.00%> (-6.09%) ⬇️
boa/src/environment/lexical_environment.rs 67.30% <ø> (-0.32%) ⬇️
...rc/syntax/parser/expression/left_hand_side/call.rs 40.42% <0.00%> (-7.08%) ⬇️
...src/syntax/parser/expression/left_hand_side/mod.rs 90.90% <ø> (ø)
boa/src/syntax/parser/function/mod.rs 63.23% <0.00%> (-0.95%) ⬇️
boa/src/syntax/lexer/template.rs 48.78% <48.64%> (-12.34%) ⬇️
boa/src/syntax/ast/node/mod.rs 47.05% <50.00%> (+0.08%) ⬆️
boa/src/syntax/parser/expression/primary/mod.rs 72.88% <50.00%> (-4.05%) ⬇️
boa/src/syntax/parser/mod.rs 53.57% <50.00%> (-1.99%) ⬇️
boa/src/syntax/lexer/string.rs 53.08% <52.17%> (+14.99%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd893c...d2d272d. Read the comment docs.

Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I think can be improved.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jasonwilliams
Copy link
Member Author

Thanks @RageKnify, merged

CHANGELOG.md Outdated Show resolved Hide resolved
@RageKnify
Copy link
Member

RageKnify commented Jan 10, 2021

Noticed that #1046 is not in the list.
edit: #1051, #1003 and #1045 too

@Razican Razican self-requested a review January 10, 2021 17:01
@tofpie
Copy link
Contributor

tofpie commented Jan 10, 2021

Need to change also the version of the new crate boa_unicode introduced in #1003

[package]
name = "boa_unicode"
version = "0.10.0"

jasonwilliams and others added 9 commits January 11, 2021 18:11
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposals for the PRs that aren't mentioned, my classifications (feature vs bug vs internal) might be wrong though.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@Razican
Copy link
Member

Razican commented Jan 12, 2021

There are 3 more PRs ready to be merged that along with #997 we should add at least some of them.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I found a couple of things that could be improved.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

@Lan2u Lan2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments already made looks good to me :)

jasonwilliams and others added 6 commits January 12, 2021 22:43
Co-authored-by: Iban Eguia <iban.eguia@cern.ch>
Co-authored-by: Iban Eguia <iban.eguia@cern.ch>
Co-authored-by: João Borges <rageknify@gmail.com>
Co-authored-by: João Borges <rageknify@gmail.com>
@jasonwilliams jasonwilliams merged commit 9160b89 into boa-dev:master Jan 14, 2021
@Razican Razican added this to the v0.11.0 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants