Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some RegExp functions I noticed, that some tests currently fail because
Value.set_field
always silently no-ops if the property is not writable. For example match sets thelastIndex
property multiple times (6.c and 6.f.iii.3.c). It uses the abstract 7.3.4 Set ( O, P, V, Throw ) operation that takes a boolean argumentthrow
and should throw if the property is not writable.I adjusted the
Value.set_field
function to make it somewhat similar to7.3.4 Set ( O, P, V, Throw )
. I adjusted all uses of the function to match the spec, if it could be referenced. For uses without clear spec reference, I just set throw to false, so that the current behavior is not impacted.I'm not sure if changing
Value.set_field
is the best way forward, but I think an internal function that matches the implementation of7.3.4 Set ( O, P, V, Throw )
is needed.