Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boa): match and regexp construct fixes #1374

Merged
merged 5 commits into from
Jul 27, 2021
Merged

fix(boa): match and regexp construct fixes #1374

merged 5 commits into from
Jul 27, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 29, 2021 •
edited by Razican
Loading

This Pull Request relates to #13.

It changes the following:

  • match method adheres to spec
  • regexp method simplified to follow spec

@neeldug
fix(boa): match and regexp construct fixes
3d3ba28 
- match method adheres to spec
- regexp method simplified to follow spec

Closes boa-dev#13
@neeldug
cleanup
4e28a22
@neeldug
revert to regex filter on construct
5dea6a2
@neeldug
fmt
990db32
@neeldug
Copy link
Contributor Author

neeldug commented Jun 29, 2021 •
edited
Loading

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 28,322 28,398 +76
Ignored 15,614 15,614 0
Failed 34,961 34,885 -76
Panics 2 2 0
Conformance 35.90% 35.99% +0.10%
Fixed tests: 
test/built-ins/String/prototype/matchAll/regexp-is-undefined.js [strict mode] (previously Failed)
test/built-ins/String/prototype/matchAll/regexp-is-undefined.js (previously Failed)
test/built-ins/String/prototype/matchAll/regexp-is-null.js [strict mode] (previously Failed)
test/built-ins/String/prototype/matchAll/regexp-is-null.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T9.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T9.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T8.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T8.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T5.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T5.js (previously Failed)
test/built-ins/String/prototype/search/cstm-search-is-null.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/cstm-search-is-null.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T11.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T11.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T12.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T12.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T4.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T4.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T10.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T10.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T7.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T7.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1.1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1.1_T1.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T13.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T13.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T9.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T9.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A2_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A2_T1.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T12.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T12.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T5.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T5.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T7.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T7.js (previously Failed)
test/built-ins/String/prototype/match/cstm-matcher-is-null.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/cstm-matcher-is-null.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T11.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T11.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T13.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T13.js (previously Failed)
test/built-ins/String/prototype/match/cstm-matcher-get-err.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/cstm-matcher-get-err.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T10.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T10.js (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T8.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/S15.5.4.10_A1_T8.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T6.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T6.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T2.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T2.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T4.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T4.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T3.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T3.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T7.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T7.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T8.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T8.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T2.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T2.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T10.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T10.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T5.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T5.js (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A3_T2.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.3.1_A3_T2.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T4.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T4.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T4.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A3_T4.js (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T1.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A4_T1.js (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js (previously Failed)

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jun 30, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 30, 2021
Razican
Razican approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

@neeldug neeldug requested a review from Razican July 26, 2021 22:26
@HalidOdat HalidOdat merged commit f93145c into boa-dev:master Jul 27, 2021
@neeldug neeldug deleted the impl-match branch July 27, 2021 12:27
@neeldug neeldug restored the impl-match branch July 27, 2021 12:27
@neeldug neeldug deleted the impl-match branch July 27, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@RageKnify RageKnify Awaiting requested review from RageKnify

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neeldug @Razican @HalidOdat