Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable obj[key] = value syntax. #161

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Enable obj[key] = value syntax. #161

merged 2 commits into from
Oct 22, 2019

Conversation

letmutx
Copy link
Contributor

@letmutx letmutx commented Oct 16, 2019

No description provided.

@letmutx
Copy link
Contributor Author

letmutx commented Oct 22, 2019

Rebased with master

jasonwilliams
jasonwilliams approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jasonwilliams jasonwilliams merged commit 0f72bf5 into boa-dev:master Oct 22, 2019
@letmutx letmutx deleted the set-keys-in-object branch October 23, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanxiyn sanxiyn sanxiyn left review comments

@jasonwilliams jasonwilliams jasonwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@letmutx @sanxiyn @jasonwilliams