Start removing non-VM path #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
+ Coverage 53.03% 56.30% +3.26%
==========================================
Files 200 200
Lines 17076 17049 -27
==========================================
+ Hits 9056 9599 +543
+ Misses 8020 7450 -570
Continue to review full report at Codecov.
|
Test262 conformance changesVM implementation
Fixed tests (783):Broken tests (114): |
|
Sadly we're seeing longer times on the VM run compared to the traditional execution. Looks like a lot of instructions are being churned out. This was expected, a lot of time is spent going back and forth between allocated objects. We haven't changed this so much here and have plans to improve that in future. I will label each instruction so the profiler shows which instruction is being used the most etc etc Here's some profiling results from https://github.com/boa-dev/boa/blob/main/boa/benches/bench_scripts/mini_js.js: VM: Exec: VM branch branch main |
Razican
requested changes
Dec 21, 2021
jasonwilliams
commented
Dec 23, 2021
Razican
reviewed
Dec 23, 2021
| @@ -1 +0,0 @@ | |||
| 1 + 1 + 1 + 1 + 1 + 1 / 1 + 1 + 1 * 1 + 1 + 1 + 1; | |||
There was a problem hiding this comment.
The reason for this benchmark was that for very long operations, the parser could overflow or be very slow. Maybe we don't want to keep it, but we should probably open a discusión on useful benchmarks.
Co-authored-by: Iban Eguia <razican@protonmail.ch>
RageKnify
requested changes
Dec 24, 2021
Razican
approved these changes
Dec 24, 2021
There was a problem hiding this comment.
I did most of the required changes, created an issue to track the safety information in the Readable trait, made it crate-only. I think it's ready to be merged, what do you think @RageKnify ?
Profile summary |
HalidOdat
added
execution
RageKnify
approved these changes
Dec 24, 2021
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Benchmarks: We definitely have a regression, but I think it's OK to merge. |
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Yeah when I get some time I’d be interested to run the profiler and see what’s going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to remove the non-vm path