Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split examples into separate executables #1898

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Mar 6, 2022

Just a general cleanup of the examples, since it is more convenient to be able to independently run any example with cargo run --bin.

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Benchmark for d2b0662

Click to view benchmark
Test Base PR %
Arithmetic operations (Compiler) 628.7±5.13ns 610.2±1.83ns -2.94%
Arithmetic operations (Execution) 2.3±0.00µs 2.3±0.00µs 0.00%
Arithmetic operations (Parser) 5.7±0.04µs 5.8±0.01µs +1.75%
Array access (Compiler) 1518.1±4.21ns 1488.7±6.76ns -1.94%
Array access (Execution) 11.6±0.02µs 11.7±0.05µs +0.86%
Array access (Parser) 12.7±0.02µs 12.8±0.02µs +0.79%
Array creation (Compiler) 2.1±0.01µs 2.1±0.01µs 0.00%
Array creation (Execution) 3.9±0.01ms 3.9±0.01ms 0.00%
Array creation (Parser) 14.3±0.02µs 14.3±0.04µs 0.00%
Array pop (Compiler) 4.7±0.02µs 4.7±0.02µs 0.00%
Array pop (Execution) 1685.1±5.87µs 1683.3±4.37µs -0.11%
Array pop (Parser) 149.2±0.11µs 149.4±0.27µs +0.13%
Boolean Object Access (Compiler) 1167.3±2.72ns 1163.6±2.90ns -0.32%
Boolean Object Access (Execution) 7.0±0.01µs 7.2±0.01µs +2.86%
Boolean Object Access (Parser) 15.9±0.04µs 16.0±0.03µs +0.63%
Clean js (Compiler) 4.0±0.01µs 3.9±0.01µs -2.50%
Clean js (Execution) 1307.8±11.28µs 1315.2±11.31µs +0.57%
Clean js (Parser) 31.1±0.04µs 31.2±0.04µs +0.32%
Create Realm 325.9±0.47ns 337.8±0.41ns +3.65%
Dynamic Object Property Access (Compiler) 1906.5±4.94ns 1898.4±4.72ns -0.42%
Dynamic Object Property Access (Execution) 8.0±0.03µs 8.1±0.03µs +1.25%
Dynamic Object Property Access (Parser) 11.3±0.02µs 11.3±0.02µs 0.00%
Fibonacci (Compiler) 2.6±0.01µs 2.7±0.01µs +3.85%
Fibonacci (Execution) 2.1±0.00ms 2.1±0.00ms 0.00%
Fibonacci (Parser) 17.5±0.03µs 17.7±0.02µs +1.14%
For loop (Compiler) 2.3±0.01µs 2.3±0.04µs 0.00%
For loop (Execution) 50.6±0.17µs 51.0±0.15µs +0.79%
For loop (Parser) 14.9±0.04µs 15.0±0.02µs +0.67%
Mini js (Compiler) 3.8±0.01µs 3.8±0.01µs 0.00%
Mini js (Execution) 1202.2±9.01µs 1212.3±8.82µs +0.84%
Mini js (Parser) 26.9±0.05µs 27.4±0.07µs +1.86%
Number Object Access (Compiler) 1118.5±3.91ns 1125.0±4.67ns +0.58%
Number Object Access (Execution) 5.5±0.02µs 5.5±0.04µs 0.00%
Number Object Access (Parser) 12.1±0.01µs 12.1±0.02µs 0.00%
Object Creation (Compiler) 1625.5±6.39ns 1630.8±9.30ns +0.33%
Object Creation (Execution) 7.2±0.03µs 7.3±0.02µs +1.39%
Object Creation (Parser) 9.9±0.03µs 10.0±0.03µs +1.01%
RegExp (Compiler) 1914.5±5.03ns 1917.2±5.33ns +0.14%
RegExp (Execution) 14.7±0.10µs 14.9±0.05µs +1.36%
RegExp (Parser) 10.8±0.06µs 10.8±0.02µs 0.00%
RegExp Creation (Compiler) 1667.3±8.61ns 1649.4±6.59ns -1.07%
RegExp Creation (Execution) 11.3±0.04µs 11.3±0.03µs 0.00%
RegExp Creation (Parser) 9.1±0.04µs 9.1±0.03µs 0.00%
RegExp Literal (Compiler) 1899.8±4.95ns 1924.7±6.18ns +1.31%
RegExp Literal (Execution) 14.9±0.08µs 14.8±0.06µs -0.67%
RegExp Literal (Parser) 8.6±0.02µs 8.7±0.05µs +1.16%
RegExp Literal Creation (Compiler) 1683.6±6.76ns 1649.7±10.81ns -2.01%
RegExp Literal Creation (Execution) 11.3±0.04µs 11.3±0.03µs 0.00%
RegExp Literal Creation (Parser) 6.9±0.02µs 6.9±0.01µs 0.00%
Static Object Property Access (Compiler) 1648.2±8.68ns 1676.2±9.46ns +1.70%
Static Object Property Access (Execution) 7.6±0.02µs 7.6±0.02µs 0.00%
Static Object Property Access (Parser) 10.6±0.02µs 10.6±0.03µs 0.00%
String Object Access (Compiler) 1591.3±9.83ns 1586.5±9.70ns -0.30%
String Object Access (Execution) 8.9±0.03µs 9.0±0.05µs +1.12%
String Object Access (Parser) 15.7±0.19µs 15.6±0.03µs -0.64%
String comparison (Compiler) 2.5±0.01µs 2.5±0.04µs 0.00%
String comparison (Execution) 6.9±0.04µs 7.0±0.03µs +1.45%
String comparison (Parser) 11.8±0.02µs 11.9±0.03µs +0.85%
String concatenation (Compiler) 1944.0±4.34ns 1937.7±3.28ns -0.32%
String concatenation (Execution) 6.3±0.04µs 6.4±0.04µs +1.59%
String concatenation (Parser) 8.0±0.02µs 8.1±0.02µs +1.25%
String copy (Compiler) 1514.9±4.24ns 1528.0±4.28ns +0.86%
String copy (Execution) 5.6±0.02µs 5.7±0.01µs +1.79%
String copy (Parser) 5.9±0.02µs 6.0±0.02µs +1.69%
Symbols (Compiler) 1087.1±2.47ns 1082.6±5.82ns -0.41%
Symbols (Execution) 5.4±0.01µs 5.4±0.01µs 0.00%
Symbols (Parser) 4.6±0.03µs 4.6±0.02µs 0.00%

@RageKnify
Copy link
Contributor

This seems to compete with #1161

@jedel1043
Copy link
Member Author

This seems to compete with #1161

I opened the PR against examples, not main

@RageKnify
Copy link
Contributor

I opened the PR against examples, not main

Sorry, my bad.

@jasonwilliams jasonwilliams merged commit 9535f99 into examples Mar 7, 2022
@bors bors bot deleted the example-bins branch March 7, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants